#7889: revolution plot
------------------------------------------------------------------+---------
   Reporter:  olazo                                               |       
Owner:  olazo          
       Type:  enhancement                                         |      
Status:  needs_work     
   Priority:  major                                               |   
Milestone:  sage-4.4       
  Component:  graphics                                            |    
Keywords:  revolution,plot
     Author:  Oscar Gerardo Lazo Arjona                           |    
Upstream:  N/A            
   Reviewer:  Karl-Dieter Crisman, Jason Grout, Marshall Hampton  |      
Merged:                 
Work_issues:                                                      |  
------------------------------------------------------------------+---------
Changes (by jhpalmieri):

  * status:  positive_review => needs_work


Comment:

 There are several problems here:

  - The patch (revolution_plot3d_3.patch -- I assume this is what I'm
 supposed to apply) doesn't apply cleanly to Sage 4.3.5.
  - This is easy to fix, but once I fix it, it shows no coverage.  I think
 this can be fixed by changing the triple quotes {{{'''}}} around the
 docstring to triple quotes {{{"""}}}.
  - Same issue: with triple quotes in the form {{{'''}}}, doctests don't
 get run.  With triple quotes {{{"""}}}, doctests run, but several of them
 fail:
 {{{
 **********************************************************************
 File
 
"/mnt/usb1/scratch/palmieri/sage-4.3.5-testing/devel/sage/sage/plot/plot3d/revolution_plot3d.py",
 line 56:
     sage: var('u')
 Expected nothing
 Got:
     u
 **********************************************************************
 File
 
"/mnt/usb1/scratch/palmieri/sage-4.3.5-testing/devel/sage/sage/plot/plot3d/revolution_plot3d.py",
 line 75:
     sage: var('u')
 Expected nothing
 Got:
     u
 **********************************************************************
 File
 
"/mnt/usb1/scratch/palmieri/sage-4.3.5-testing/devel/sage/sage/plot/plot3d/revolution_plot3d.py",
 line 89:
     sage: var('u')
 Expected nothing
 Got:
     u
 **********************************************************************
 File
 
"/mnt/usb1/scratch/palmieri/sage-4.3.5-testing/devel/sage/sage/plot/plot3d/revolution_plot3d.py",
 line 95:
     sage: var('u')
 Expected nothing
 Got:
     u
 **********************************************************************
 File
 
"/mnt/usb1/scratch/palmieri/sage-4.3.5-testing/devel/sage/sage/plot/plot3d/revolution_plot3d.py",
 line 97:
     sage:
 
revolution_plot3d(curve,(u,0,pi),(0,pi/2),show_curve=True,parallel_axis='z',opacity=0.5).show(aspect_ratio=(1,1,1),frame=False)
 Expected nothing
 Got:
     ta
 **********************************************************************
 1 items had failures:
    5 of  22 in __main__.example_0
 ***Test Failed*** 5 failures.
 For whitespace errors, see the file
 /home/palmieri/.sage//tmp/.doctest_revolution_plot3d.py
          [6.8 s]

 ----------------------------------------------------------------------
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7889#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to