#8649: to_tableau method broken for crystals of type B
------------------------------+---------------------------------------------
Reporter: aschilling | Owner: sage-combinat
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.4
Component: combinatorics | Keywords: crystals
Author: Anne Schilling | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by bump):
* status: needs_review => positive_review
Comment:
Before the patch, the to_tableau method of crystals of tableaux could
return a tableau with the wrong shape. I did a lot of testing of the fix.
I found that there were problems with type B crystals, but also for type
G2. (Crystal of letters, and hence crystals of tableaux are implemented
for Type G2 even though this method of producing crystals may not be
appropriate for other exceptional types.)
After the patch I found no problems after testing a lot of crystals of
various Cartan types. In order to test a crystal, I simply verified that
all elements v have the same {{{v.to_tableau().shape()}}}.
I also ran sage -testall and all tests pass.
The {{{__call__}}} method is also changed to {{{_element_constructor_}}}
for the reason given in the patch description. This does not seem to break
anything.
My conclusion is that the patch is correct and fixes a bad book. It should
be merged.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8649#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
