#8156: [with code] new function readdata
-------------------------------+--------------------------------------------
Reporter: zimmerma | Owner: was
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.4
Component: interfaces | Keywords:
Author: Paul Zimmermann | Upstream: N/A
Reviewer: Tim Dumol | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by jhpalmieri):
* status: positive_review => needs_work
Comment:
On sage.math, I get doctest failures:
{{{
sage -t "devel/sage/sage/interfaces/read_data.py"
**********************************************************************
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/devel/sage/sage/interfaces/read_data.py",
line 24:
sage: !echo "17" > in.data; echo "42" >> in.data
Exception raised:
Traceback (most recent call last):
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_1[2]>", line 1
!echo "17" > in.data; echo "42" >> in.data###line 24:
sage: !echo "17" > in.data; echo "42" >> in.data
^
SyntaxError: invalid syntax
**********************************************************************
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/devel/sage/sage/interfaces/read_data.py",
line 25:
sage: cat in.data
Exception raised:
Traceback (most recent call last):
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_1[3]>", line 1
cat in.data###line 25:
sage: cat in.data
^
SyntaxError: invalid syntax
**********************************************************************
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/devel/sage/sage/interfaces/read_data.py",
line 28:
sage: l = read_data("in.data", ZZ); l
Exception raised:
Traceback (most recent call last):
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_1[4]>", line 1, in <module>
l = read_data("in.data", ZZ); l###line 28:
sage: l = read_data("in.data", ZZ); l
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/lib/python/site-
packages/sage/interfaces/read_data.py", line 34, in read_data
fp = open(f,"r")
IOError: [Errno 2] No such file or directory: 'in.data'
**********************************************************************
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/devel/sage/sage/interfaces/read_data.py",
line 30:
sage: !echo "1.234" > in.data; echo "5.678" >> in.data
Exception raised:
Traceback (most recent call last):
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_1[5]>", line 1
!echo "1.234" > in.data; echo "5.678" >> in.data###line 30:
sage: !echo "1.234" > in.data; echo "5.678" >> in.data
^
SyntaxError: invalid syntax
**********************************************************************
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/devel/sage/sage/interfaces/read_data.py",
line 31:
sage: l = read_data("in.data", RealField(17)); l
Exception raised:
Traceback (most recent call last):
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_1[6]>", line 1, in <module>
l = read_data("in.data", RealField(Integer(17))); l###line 31:
sage: l = read_data("in.data", RealField(17)); l
File
"/mnt/usb1/scratch/palmieri/sage-4.4.alpha0-testing/local/lib/python/site-
packages/sage/interfaces/read_data.py", line 34, in read_data
fp = open(f,"r")
IOError: [Errno 2] No such file or directory: 'in.data'
**********************************************************************
1 items had failures:
5 of 7 in __main__.example_1
***Test Failed*** 5 failures.
}}}
For portability, it might be better to use Python for the doctests:
something like
{{{
sage: f = open("in.data", "w")
sage: f.write("17\n42")
sage: f.close()
etc.
}}}
Also, line 29, {{{[17. 42]}}} looks suspicious: should that period be a
comma?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8156#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
