#8446: avoid 0^0 in number fields
-----------------------------+----------------------------------------------
Reporter: rlm | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4
Component: number fields | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Comment(by davidloeffler):
Looks fine, and all doctests pass. FWIW, I think that there should be a
doctest in {{{_S_class_group_and_units}}}, not just in {{{selmer_group}}},
as that's where the problem actually occurs; and the docstring for
{{{selmer_group}}} contains the literal string {{{\t}}} so it should be a
raw string. Hence the tiny second patch. I'm giving this a positive review
modulo that, so please set it to positive review if you're happy with the
second patch.
BTW, I tried using this for some some relative extensions and discovered
two separate new bugs in the process, #8721 and #8722. Neither of these
actually has anything to do with this patch as such, it's preexisting
brokenness. I know what's causing #8722; I'll upload a patch shortly --
any chance you could review it for me?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8446#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
