#8737: compile plot3d/base.pyx and index_face_set with "-std=c99"
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: drkirkby
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.4
Component: graphics | Keywords:
Author: John Palmieri | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by drkirkby):
* owner: jason, was => drkirkby
Comment:
I would rephrase the question and ask why are people adding -D_XPG6? Can
they justify it?
We can justify adding -std=c99, as we want to make use of a feature that
was not defined until the C99 standard. I don't know of any justification
for adding -D_XPG6. (That is not to say there is not any, but I think the
onus should be on someone who adds -D_XPG6 to justify why they add it.)
There are quite a few bits of code in Sage which appear to be added just
because someone else did so before, without anyone understanding why they
did it. One sees things like
{{{
path="$SAGE_LOCAL"/bin
}}}
when it should be:
{{{
path="$SAGE_LOCAL/bin"
}}}
I suspect people are just cutting/pasting without any understanding.
I think it is better to just leave it as -std=c99, until such time as
someone can justify why -D_XPG6 is best added.
Please note, I'm not saying -D_XPG6 might not be right, but only that I'd
rather not add things we don't understand.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8737#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
