#8730: [needs review] cddlib makefile looks for gmp in /usr/local, should be
$SAGE_LOCAL
-----------------------+----------------------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.4
Component: algebra | Keywords:
Author: vbraun | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------+----------------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
I agree with Dima in that the fact patches/autogenerated has files
autogenerated by running autoreconf should be stated in SPKG.txt - not
just the tickets. It is not obvious to someone that does not know
autoconf/automake well.
Also, I believe the directory autom4te.cache should be copied too. When
'autoreconf' is run, it creates that directory. The only file in there
which says it can be safely removed is autom4te.cache/requests. There is
nothing to indicate to me that is is safe to remove the other files from
autom4te.cache. One might get away with it, but I think it is wrong to not
include them. Note this directory is created by autoreconf - not when one
runs the configure script.
Whoever wrote the cddlib package in the first place clearly did not
understand autoconf/automake. The whole point of using autoconf/automake
is to create a configure script where things like the locations of the
libraries can be specified as options - they should not be hard-coded in
Makefile.am like they are. The file Makefile.am starts with "Site
customizations:" which should not be necessary.
Also, there is a file "ChangeLog?" and another "ChangeLog? (Autosaved)" in
the src directory. Couple that with facts there is no LICENSE file,
History/News/ChangeLog are all the same, and you get the feeling the
developers did not understand autoconf/automake.
What I find strange is that libgmp has been in /usr/local/lib for almost
10 months on 't2'
kir...@t2:[/usr/local/lib] $ ls -l /usr/local/lib/libgmp*
-rw-r--r-- 1 nobody nobody 659804 Jun 27 2009
/usr/local/lib/libgmp.a
-rwxr-xr-x 1 nobody nobody 785 Jun 27 2009
/usr/local/lib/libgmp.la
lrwxrwxrwx 1 nobody nobody 15 Jun 27 2009
/usr/local/lib/libgmp.so -> libgmp.so.3.5.0
lrwxrwxrwx 1 nobody nobody 15 Jun 27 2009
/usr/local/lib/libgmp.so.3 -> libgmp.so.3.5.0
-rwxr-xr-x 1 nobody nobody 355108 Jun 27 2009
/usr/local/lib/libgmp.so.3.5.0
kir...@t2:[/usr/local/lib] $
Why this should suddenly be a problem is a bit puzzling to me, given
cddlib-094f.p5.spkg was merged into sage 4.3.4 and 4.3.4 built on 't2' OK.
Does anyone know why this suddenly stops working?
But in principle, I think changing Kakefile.am and regenerating the files
with autoreconf is the way to go. I'm just a bit concerned that the
autom4te.cache directory is not included.
I think it is important to point out to the upstream developers that
having a site customisation file Makefile.am goes totally against the
principle of using autoconf/automake.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8730#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
