#8378: [trivial to fix] typo in documentation of crt
--------------------------------+-------------------------------------------
Reporter: zimmerma | Owner: AlexGhitza
Type: defect | Status: needs_work
Priority: trivial | Milestone: sage-4.4
Component: basic arithmetic | Keywords:
Author: Paul Zimmermann | Upstream: N/A
Reviewer: John Cremona | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by cremona):
* status: needs_review => needs_work
* reviewer: => John Cremona
Comment:
Of course this patch is fine (it applies OK to 4.4.alpha1).
Looking at this function and its docstring, though, these thoughts occur
to me:
1. If the condition gcd(m,n) is required, it should be documented in
the INPUT block (which is missing); and there should be a test to show
what happens when the condition fails.
2. As we all know, there exists a solution iff gcd(m,n) divides a-b.
So why not generalise the function to allow for this case too? It would
only take a small change to the code, and of course the documentation
would also need chenging. (The solution is unique modulo lcm(m,n), not
m*n, in general).
I happen to have just been teaching this!
Paul, if you fancy upgrading your patch, go ahead. Or you could ask me to
do it since I'm the one who has made difficulties!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8378#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
