#7630: Require email confirmation before account activation
------------------------+---------------------------------------------------
Reporter: jason | Owner: was
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.4
Component: notebook | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by was):
* status: needs_review => needs_work
Comment:
Replying to [comment:9 ddrake]:
> Replying to [comment:8 jason]:
> > Is this really "needs review"? The last few comments seem to indicate
that it is still "needs work".
>
> Well, there's lots of print statements throughout the code, and I
decided to leave those in for reviewing purposes. When I was working on
this, I found it very hard to follow the execution path, so I put in lots
of "prints" -- it seems like a reviewer would also appreciate the help in
seeing what's happening.
>
> After the patch gets a good review, I can add a small remove-all-the-
prints patch.
Please make all the print statements conditional, e.g., write a function
{{{
def log_devel(s):
if VERBOSE: print s
}}}
and call that function everywhere. Then make a file-scope variable
VERBOSE which is False in your patch.
Explain here (and in a comment) that by setting it to True, the reviewer
can enable devel logging. This'll get
used elsewhere too.
-- William
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7630#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
