#8378: typo in documentation of crt
---------------------------------------------+------------------------------
Reporter: zimmerma | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-4.4
Component: basic arithmetic | Keywords:
Author: Paul Zimmermann, John Cremona | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------------------+------------------------------
Changes (by newvalueoldvalue):
* status: needs_work => needs_review
* reviewer: John Cremona =>
* author: Paul Zimmermann => Paul Zimmermann, John Cremona
Old description:
> {{{
> sage: crt(15,1,30,4)
> ...
> ValueError: arguments a and b must be coprime
> }}}
> However in the documentation of {{{crt}}} a, b are the residues,
> and the moduli are called m, n. Thus the message should be:
> {{{
> ValueError: arguments m and n must be coprime
> }}}
New description:
{{{
sage: crt(15,1,30,4)
...
ValueError: arguments a and b must be coprime
}}}
However in the documentation of {{{crt}}} a, b are the residues,
and the moduli are called m, n. Thus the message should be:
{{{
ValueError: arguments m and n must be coprime
}}}
Additionally, this function should be extended to handle non-coprime
moduli.
--
Comment:
My patch trac_8378-crt.patch replaces Paul's (though note that it still
has Paul's user id in it). It extends the crt function to handle non-
coprime moduli sensibly, with additional doctests.
This also means that the typo in the error message which Paul's patch
fixed has now changed even more, so that in effect the effect of original
patch is obsolete.
One might now argue for a greater change in the title of the ticket, and
a change from the tag "defect" to "enhancement". I am not bothered -- I
hope Paul does not mind my having totally taking over this ticket! We
probably need an independent review anyway.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8378#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
