#8765: Huffman Encoding
-------------------------------+--------------------------------------------
Reporter: ncohen | Owner: wdj
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.1
Component: coding theory | Keywords:
Author: Nathann Cohen | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Changes (by mvngu):
* reviewer: => Minh Van Nguyen
Old description:
> This is a basic implementation of Huffman's encoding. May it be useful to
> teach ! :-)
>
> Apply patches in this order:
>
> 1.
> [http://trac.sagemath.org/sage_trac/attachment/ticket/8765/trac_8765-huffman.patch
> trac_8765-huffman.patch]
New description:
This is a basic implementation of Huffman's encoding. May it be useful to
teach ! :-)
Apply patches in this order:
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8765/trac_8765-huffman.patch
trac_8765-huffman.patch]
1. [http://trac.sagemath.org/sage_trac/attachment/ticket/8765/trac_8765
-clean-ups.patch trac_8765-clean-ups.patch]
--
Comment:
Changes in the reviewer patch include:
1. Add substantially more documentation to the module.
1. Clean-ups in accordance with [http://www.python.org/dev/peps/pep-0008/
PEP 008].
1. Don't use the module `string` nor its `join` function. These have been
deprecated. You should now use `str` and the function `"".join`.
1. Get the whole module to 100% coverage.
This means I have reviewed
[http://trac.sagemath.org/sage_trac/attachment/ticket/8765/trac_8765-huffman.patch
trac_8765-huffman.patch], so only my patch needs review by anyone but me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8765#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
