#8380: Implement an interface to GAP3
------------------------------+---------------------------------------------
Reporter: saliola | Owner: Franco Saliola
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.2
Component: interfaces | Keywords: gap3, chevie, specht, gap,
sage-combinat
Author: Franco Saliola | Upstream: N/A
Reviewer: Burcin Erocal | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by burcin):
* status: needs_review => needs_work
* reviewer: => Burcin Erocal
Comment:
I tested attachment:gap3_interface_v4.3.3.patch on Sage-4.4.1 with gap3
installed using [http://www.math.rwth-
aachen.de:8001/~Frank.Luebeck/gap/GAP3/index.html Frank Luebeck's
distribution]. The patch applies cleanly, but there are many doctest
failures. This could be due to the fact that optional packages like chevie
are not included in this distribution of GAP3.
Here is my review for the patch:
* There is no doctest for the change in `sage/interfaces/expect.py`
* The method `load_package()` in `sage/interfaces/gap.py` doesn't have a
doctest. I understand that this is copied as is from the old version, but
if there is any package that is included by default in the GAP4
distribution (or one which we include in our package), we should add a
test.
* In `sage/interfaces/gap3.py`
* Is the bug in the pexpect interface mentioned around line 42 reported
on trac? Can you mention the ticket number in that comment. Is this
specific to the GAP interface?
* does the GAP3 banner depend on the specific package installed?
* There are some doctests that depend on chevie,
(`RequirePackage('"chevie"')` and `load_package("chevie")`), these should
be optional.
* The docstring for `GAP3Record.__getattr__` ends with " :: " then an
empty line. There are many places where there is an empty line at the end
of the docstring, or right after.
The optional package for gap3 in comment:9 looks good in general. Maybe
the fact that it's binary only can be made more obvious, for example by
adding a `bin` to the package name.
BTW, it's not possible to install the version of GAP3 downloaded from the
main web site (http://www.gap-system.org/Gap3/Download3/download.html)
easily. I suggest moving the link to Frank Luebeck's distribution to the
first place, and putting this option last.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8380#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
