#8364: Forward options like "solver" in all the functions using LP
-------------------------------------------------------------------------+--
Reporter: ncohen |
Owner: jkantor
Type: enhancement |
Status: needs_work
Priority: major |
Milestone: sage-4.4.2
Component: graph theory |
Keywords:
Author: |
Upstream: N/A
Reviewer: schilly |
Merged:
Work_issues: rebase on top of #7671, #7854, #7966, #8273, #8273, #8331 |
-------------------------------------------------------------------------+--
Changes (by jason):
* status: needs_review => needs_work
Comment:
I like this patch. Two comments:
Applying to 4.4.2.alpha0 gives:
{{{
applying trac_8364.patch
patching file sage/graphs/generic_graph.py
Hunk #13 FAILED at 3526
Hunk #14 FAILED at 3639
Hunk #17 succeeded at 3566 with fuzz 1 (offset -227 lines).
Hunk #20 succeeded at 3838 with fuzz 1 (offset -226 lines).
Hunk #22 succeeded at 3907 with fuzz 1 (offset -227 lines).
Hunk #24 succeeded at 3997 with fuzz 2 (offset -226 lines).
Hunk #27 succeeded at 4206 with fuzz 2 (offset -225 lines).
2 out of 29 hunks FAILED -- saving rejects to file
sage/graphs/generic_graph.py.rej
patching file sage/graphs/graph.py
Hunk #3 succeeded at 1470 with fuzz 1 (offset -1 lines).
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_8364.patch
}}}
Second: about half of the docstrings for the solver option seem to be
missing words. I like the solver option docstring that is given for
feedback_vertex_set the best.
With those two changes, this should be an easy, quick review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8364#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
