#8960: doctest coverage for real_mpfr.pyx
--------------------------------+-------------------------------------------
Reporter: jason | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.2
Component: basic arithmetic | Keywords:
Author: Jason Grout | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Minh Van Nguyen
* author: => Jason Grout
Old description:
> This patch works on doctest coverage.
New description:
This patch works on doctest coverage.
'''Apply:'''
1. [http://trac.sagemath.org/sage_trac/attachment/ticket/8960/trac-8960
-RealField-docs.patch trac-8960-RealField-docs.patch]
1.
[http://trac.sagemath.org/sage_trac/attachment/ticket/8960/trac_8960-reviewer.patch
trac_8960-reviewer.patch]
--
Comment:
Changes in the reviewer patch include:
* Typo fixes.
* Fix errors/warnings with LaTeX markups in docstrings.
* Use error types, e.g. !IndexError, etc., as callables in accordance
with Python 3.x.
* Don't LaTeX expressions wherever that makes sense. For example,
something like
{{{
`self`
}}}
would actually LaTeX the word "self".
Incidentally, I came across the following line
{{{
elif PY_TYPE_CHECK(x, gen) and typ((<gen>x).g) == t_REAL:
}}}
from the function
{{{
cdef _set(self, x, int base):
# This should not be called except when the number is being
created.
# Real Numbers are supposed to be immutable.
<...>
}}}
Notice the call
{{{
typ((<gen>x).g)
}}}
Should this be
{{{
type((<gen>x).g)
}}}
That is, use "type" instead of "typ"?
[[BR]]
Apart from the above, I'm OK with Jason's changes. So only my patch needs
review by anyone but me.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8960#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
