#8207: Factoring a constant generic multivariate polynomial broken
-----------------------+----------------------------------------------------
Reporter: wjp | Owner: AlexGhitza
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.4.2
Component: algebra | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------+----------------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
Comment:
The patch looks fine to me, applies ok to 4.4.2.rc0 and all tests in
sage/rings/polynomial pass.
Looking at the code in this file, some of it seems very over-complicated
-- do people agree? The is_univariate() function could just return
self.nvariables()<2. And the conversion to univariate function (which
this patch patches) could more simply, after constructing the ring R as
now, return {{{f([R.gen()]*f.parent().ngens())}}} saving 20 complicated
lines.
I am copying in malb who may have an opinion. If people agree we could
open a ticket for simplifying these. But this patch gets a positive
review from me anyway.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8207#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
