#8950: new function for sage.calculus.desolve module
------------------------------+---------------------------------------------
Reporter: uri | Owner: burcin
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.4.3
Component: calculus | Keywords: desolve
Author: Oriol Castejon | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by burcin):
* status: needs_review => needs_work
* milestone: => sage-4.4.3
Comment:
Thanks for the patch, it looks like a good start.
Here are a few comments (not a formal review):
* You should change your code to conform to the Python coding
conventions: http://sagemath.org/doc/developer/conventions.html#python-
coding-conventions
In particular,
* use 4 spaces for indentation
* try not to have lines exceeding 80 characters (some of us use old
fashioned command line editors)
* change the ComputeJacobian argument.
* Your function doesn't seem to do anything, comparing with the previous
attachment:desolve_numerical.py a whole chunk of code starting with the
`else` clause corresponding to the second `if` statement seems to be
missing
* You should use y[:] to copy a list
* Other functions in the same file also solve differential equations
numerically. Choosing a more specific name for your function might be more
appropriate.
Someone who uses this functionality more often should comment on the
content and the name of the function.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8950#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
