#8781: Overfull graph (and a bug in edge_coloring)
-------------------------------+--------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.3
Component: graph theory | Keywords:
Author: Nathann Cohen | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by mvngu):
Replying to [comment:5 ncohen]:
> I noticed an error in the docstrings though... so positive review to
your patch, and this ticket is still waiting for review because of mine.
Your fix is OK by me. However, note that it requires GLPK or CBC. (I have
only tested with those two spkg's.) Without any of those packages
installed, I got the following failure:
{{{
#!sh
sage -t -long "devel/sage-main/sage/graphs/generic_graph.py"
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/devel/sage-
main/sage/graphs/generic_graph.py", line 1845:
sage: edge_coloring(g, value_only=True)
Expected:
3
Got:
4
**********************************************************************
File "/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/devel/sage-
main/sage/graphs/generic_graph.py", line 4027:
sage: g.matching(algorithm="LP", value_only=True)
Exception raised:
Traceback (most recent call last):
File
"/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_69[5]>", line 1, in <module>
g.matching(algorithm="LP", value_only=True)###line 4027:
sage: g.matching(algorithm="LP", value_only=True)
File "/dev/shm/mvngu/sandbox/sage-4.4.2.sandbox.6/local/lib/python
/site-packages/sage/graphs/generic_graph.py", line 4078, in matching
return p.solve(objective_only=True, solver=solver, log=verbose)
File "mip.pyx", line 1051, in
sage.numerical.mip.MixedIntegerLinearProgram.solve
(sage/numerical/mip.c:7884)
ValueError: There does not seem to be any (Mixed) Integer Linear
Program solver installed. Please visit
http://www.sagemath.org/doc/constructions/linear_programming.html to learn
more about the solvers available.
**********************************************************************
}}}
So I have made the doctest optional. And as I said before: Anyone for a
final review of the whole ticket? :-) See the ticket description for
instructions on how to apply patches.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8781#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
