#9035: add degree argument to univariate polynomial reverse() method
--------------------------------+-------------------------------------------
Reporter: burcin | Owner: AlexGhitza
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-4.4.3
Component: basic arithmetic | Keywords:
Author: Burcin Erocal | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
Comment:
Patch applies fine to 4.4.3.alpha0, and looks good to me.
Tests pass (I tested all files in sage/rings/polynomial plus some other
random tests).
I am giving this a positive review, but wonder whether the following
reverse functions should also be changed to be consistent:
{{{
libs/ntl/ntl_GF2X.pyx:645: def reverse(self, int hi = -2):
libs/ntl/ntl_ZZX.pyx:768: def reverse(self, hi=None):
libs/ntl/ntl_ZZ_pEX.pyx:850: def reverse(self, hi=None):
libs/ntl/ntl_ZZ_pX.pyx:947: def reverse(self, hi=None):
...
rings/polynomial/polynomial_modn_dense_ntl.pyx:1005: def reverse(self):
rings/polynomial/polynomial_modn_dense_ntl.pyx:1548: def reverse(self):
rings/polynomial/polynomial_real_mpfr_dense.pyx:484: def reverse(self):
...
rings/polynomial/padics/polynomial_padic_capped_relative_dense.py:840:
def reverse(self, n = None):
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9035#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
