#8810: Implementation of Stanley symmetric functions
---------------------------------------------------------+------------------
Reporter: aschilling | Owner:
sage-combinat
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
Component: combinatorics | Keywords:
Author: Steve Pon, Nicolas Thiery, Anne Schilling | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------------------------------+------------------
Changes (by jbandlow):
* status: needs_review => needs_work
Comment:
I'm just starting this review, and I will probably have more to say, but
here some initial issues. In the file weyl_groups.py:
* The methods `exp_poly_to_sym`, `pieri_factors`, and `is_pieri_factor`
are missing doctests.
* Do you think `exp_poly_to_sym` has general use? If so, it should
probably be placed in the symmetric function code somewhere. If not, it
should probably be made private (eg. `_exp_poly_to_sym`)
* In `exp_poly_to_sym`, you should replace
{{{ R._from_dict(dict( ... ) }}}
with
{{{ R.sum_of_terms( ... ) }}}
* In the doc for `pieri_factors`: "Those are used.." should be "These
are used..", "For any types" should be "For any type"
* In each of the methods `pieri_factors`, `is_pieri_factor`, and
`left_pieri_factorizations` a reference in the doc to the
'pieri_factors.py` file (where pieri factors are described in more detail)
would be nice.
* Some reference to a definition of a Stanley symmetric function should
be given in the doc to the `stanley_symmetric_..` methods.
* The latex in the doc for `left_pieri_factoriztions` is not properly
marked up.
* In the doc for `stanley_symmetric_function_as_polynomial`, I don't
understand the phrase "The results is given in the ring of symmetric
functions in the elementary basis, each factorization having weight prod_i
x_i". Can you explain this more fully?
There is a lot of really cool new functionality here. I'm looking forward
to it getting in to sage. I'll try to finish this review soon.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8810#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
