#8876: Allows triangular morphisms to have domain and codomain with different
index sets
------------------------------+---------------------------------------------
Reporter: hivert | Owner: hivert
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.4.4
Component: categories | Keywords: Triangular Morphisms
Author: Florent Hivert | Upstream: N/A
Reviewer: Jason Bandlow | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by hivert):
* status: needs_review => positive_review
Old description:
> Currently triangular morphisms required to have domain and codomain with
> the
> same index sets. The patch remove this limitation by having
> !TriangularMorphism accept a new argument {{{inverse_on_support}}}. It is
> supposed to be a function `r : J |--> I` returning the leading term `i`
> from the one of `j = on_basis(i)`. This is used by: {{{preimage}}} and
> {{{section}}}.
>
> I also wrote the methods {{{co_kernel_projection}}}, {{{co_reduced}}},
> and
> {{{_test_triangular}}}.
New description:
Currently triangular morphisms required to have domain and codomain with
the
same index sets. The patch remove this limitation by having
!TriangularMorphism accept a new argument {{{inverse_on_support}}}. It is
supposed to be a function `r : J |--> I` returning the leading term `i`
from the one of `j = on_basis(i)`. This is used by: {{{preimage}}} and
{{{section}}}.
I also wrote the methods {{{co_kernel_projection}}}, {{{co_reduced}}}, and
{{{_test_triangular}}}.
Depend on #8881 and #8742, Apply patch in that order:
- [http://trac.sagemath.org/sage_trac/attachment/ticket/8876/trac_8876
-triangular_morphisms_improve-fh.patch trac_8876
-triangular_morphisms_improve-fh.patch]
- [http://trac.sagemath.org/sage_trac/attachment/ticket/8876/trac_8876
-reviewer_patch-jb.patch trac_8876-reviewer_patch-jb.patch]
--
Comment:
Everything was ok with the following patch applied:
{{{
trac_8881-functorial_constructions-nt.patch
trac_8742-lazy_format-fh.patch
trac_8742-lazy_format-review-nt.patch
trac_8876-triangular_morphisms_improve-fh.patch
trac_8876-reviewer_patch-jb.patch
}}}
Thanks for the review and the corrections. Your patch is good. Positive
review
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8876#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
