#9114: Improve documentation of infinite polynomial rings
-----------------------------------+----------------------------------------
Reporter: SimonKing | Owner: Simon King
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.4.4
Component: commutative algebra | Keywords: documentation, infinite
polyonomial ring, symmetric reduction
Author: Simon King | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------------+----------------------------------------
Comment(by davidloeffler):
Looks fine to me; it builds and passes tests under 4.4.4.alpha0, the tests
pass in a reasonable length of time (25 seconds on my machine, as opposed
to 17 seconds without "-long" and a ridiculously long time with "-long").
Documentation builds OK and looks good.
There is one minor problem: quite a few doctests are marked with "#
indirect doc test" (with space), while the coverage script looks for "#
indirect doctest". I have fixed these and added a few more doctests. (I
also streamlined the {{{__contains__}}} methods slightly, since all they
did was try to convert x into self and then test equality, which the
coercion framework does automatically anyway.) All four files relating to
infinite polynomial rings now pass {{{sage -coverage}}} with no
complaints.
Simon: if you are happy with the changes in my reviewer patch, then feel
free to put the status to "positive review".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9114#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
