#9066: Improve documentation in shapes2.py
-----------------------------------+----------------------------------------
Reporter: kcrisman | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.4.4
Component: documentation | Keywords:
Author: Karl-Dieter Crisman | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-----------------------------------+----------------------------------------
Changes (by mvngu):
* reviewer: => Minh Van Nguyen
Comment:
I'm OK with kcrisman's patch, except for a few points which I have added
in my reviewer patch. Changes in the reviewer patch include:
* Use the new style of raising exceptions, e.g. use `TypeError` as if
it's a function, not a statement. This new style is more consistent with
Python 3.x. When it comes time to switch to using Python 3.x, there would
be less work involved in making the transition to Python 3.x.
* Put exception tests into a `TESTS` block.
* Fix up docstring in `bezier3d` so it renders nicely in the reference
manual.
* Some miscellaneous typo fixes.
If my patch gets a positive review, the whole ticket is good to go.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9066#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
