#9112: adding maximum entry option to SemistandardTableaux()
-----------------------------+----------------------------------------------
Reporter: QuantumKing | Owner: QuantumKing
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.4
Component: combinatorics | Keywords: semistandard tableaux
Author: Eric Webster | Upstream: N/A
Reviewer: Jason Bandlow | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by jbandlow):
* reviewer: => Jason Bandlow
Comment:
This looks good for the most part. I've uploaded a reviewer patch which
fixes some failing doctests, changes `__repr__` to `_repr_` throughout the
file, improves some docstrings, and improves the efficiency of
`__contains__` for semistandard tableaux. There is a lot more that can be
done with this file, but these patches make sage better and there is no
reason for them not to go in right away. I'll open another ticket for
general cleanup of tableau.py.
So, in short, I give a positive review to the patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/9112/trac_9112_tableau_py.patch]
, provided my reviewer patch is applied on top of it. So now someone
(possibly the original author) needs to approve the reviewer patch, and
the ticket can be marked as positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9112#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
