#4446: New module complex_mpc using lib mpc for complex multiprecision
arithmetic
--------------------------------+-------------------------------------------
Reporter: thevenyp | Owner: mabshoff
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.4.4
Component: basic arithmetic | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
In the spkg-install I see above:
{{{
if [ `uname` = "Darwin" -a "$SAGE64" = "yes" ]; then
echo "64 bit MacIntel"
CFLAGS="-O2 -g -m64 -fPIC"; export CFLAGS
CXXLAGS="-O2 -g -m64 -fPIC"; export CXXFLAGS
LDFLAGS="-m64 "; export LDFLAGS
else
CFLAGS="-O2 -g -fPIC"; export CFLAGS
fi
}}}
This will cause an issue that plagues a 64-bit port to !OpenSolaris and
Solaris 10. There is no reason to restrict the -m64 flag to be just OS X.
It should be changed to:
{{{
if [ "x$SAGE64" = xyes ]; then
echo "Building a 64-bit version of MPC"
CFLAGS="-O2 -g -m64 -fPIC"; export CFLAGS
CXXLAGS="-O2 -g -m64 -fPIC"; export CXXFLAGS
LDFLAGS="-m64 "; export LDFLAGS
else
CFLAGS="-O2 -g -fPIC"; export CFLAGS
fi
}}}
Was there a good reason for unsetting 'RM' in the spkg-install, or was it
just one copied from some other package, which happened to do that?
Most packages use
* configure
* make
* make install
checking the error code of each of the 3 stages. This does
* configure
* make install
If 'make install' fails, there is no way to know if the build or
installation failed.
See
http://www.sagemath.org/doc/developer/producing_spkgs.html#creating-a-new-
spkg
for some information on that. I note looking at the above link, there is
no code which does anything when SAGE64 is set to "yes". That is in my
mind an error in the documentation. Clearly that was written even before a
64-bit OS X port was attempted.
Also, SPKG.txt is an empty file - again see that link above for how that
should be created.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4446#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
