#8562: Categories for IntegerMod rings
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.4.4
Component: algebra | Keywords: categories, integer mod rings
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Comment(by nthiery):
Hi John!
Thanks much for rebasing the patch. I looked through the changes, and am
happy to give my green light, up to three minor comments:
* Is the convention to use as ticket summary "trac 8562:" or "#8562:"? (I
personally prefer the later).
* With the updated patch, sage -coverage complains because of the absence
of #indirect doctest for create_object in
sage/rings/finite_rings/integer_mod_ring.py. Just wanted to check; if this
is voluntary, because you consider that this requires better tests, that's
all fine with me.
* I like the options {{{nodates=1}}} and {{{showfunc = 1}}} of hg :-)
I let you set up the positive review as you feel appropriate.
Thanks again,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8562#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
