#9111: modular decomposition
-----------------------------------------------------+----------------------
Reporter: ncohen | Owner: jason,
ncohen, rlm
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-4.4.4
Component: graph theory | Keywords:
Author: Nathann Cohen, Thierry de Montgolfier | Upstream: N/A
Reviewer: Robert Miller, ? | Merged:
Work_issues: |
-----------------------------------------------------+----------------------
Changes (by newvalueoldvalue):
* reviewer: => Robert Miller, ?
* author: => Nathann Cohen, Thierry de Montgolfier
Comment:
Replying to [comment:5 ncohen]:
> 2. I mean by this that the lines of the code building the graph
according to the format used in the .c file, along with the ones reading
the decomposition once it is computed, can be found in the .c files too. I
copied those and Cythonized them, but the "real" code is still contained
in the .c file.
Can you make this a bit more clear in the documentation? (Please, in a new
patch on top of attachment:trac_9111-doc-edits.patch to avoid conflict
with the other patch.)
It seems like there should be more thorough documentation of the idea of
modular decomposition. Perhaps a chapter, or at least a chunk, for the
reference manual, or a guided tour or something? I don't want to block
this from getting merged because of this, but maybe in a future ticket?
I'm happy with this patch in that it passes its tests and the docs look
good, but I'd be much more comfortable with a second reviewer, since I'm
not very familiar with modular decompositions. I can certainly offer half
of a positive review, though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9111#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
