#8552: replace os.system calls in latex.py with appropriate replacements
-----------------------------+----------------------------------------------
Reporter: ddrake | Owner: tbd
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: misc | Keywords:
Author: Dan Drake | Upstream: N/A
Reviewer: John Palmieri | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* reviewer: => John Palmieri
* author: => Dan Drake
Comment:
Overall, it looks good.
I think line 615, {{{debug=True}}} should be deleted. I also think that
before line 1793
{{{
print 'viewer: "{0}"'.format(viewer)
}}}
we should have {{{if debug:}}}
I notice that you don't seem to be using "base" in the switch from
{{{
lt = 'cd "%s"&& sage-native-execute %s \\\\nonstopmode \\\\input{%s.tex}
%s'%(base, command, filename, redirect)
}}}
to
{{{
lt = ['sage-native-execute', command, r'\nonstopmode', r'\input{' +
filename + '.tex}']
}}}
But it seems to work with your patch, so I guess it's okay.
> is it okay if we just eliminate that [background] option?
I think so. If you think it's worth asking around, you could post on
sage-devel. Anyway, I think we can eliminate it, but we should probably
keep the argument there for backwards compatibility, but have it do
nothing -- this is what your patch does, right? We (meaning you) just
need to document that the option no longer does anything.
> Another issue: the viewer commands from misc.viewer on Linux all return
strings with a space in them
If "s" is the output of one of these commands, can we do s.split() to turn
it into a list, split at spaces (if there are any)? Oh, I guess that's
what you're doing.
----------
Summary: fix the debugging issues (the print statement), and document the
fact that "do_in_background" now has no effect, and I think this is ready
to go.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8552#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
