#9334: hilbert symbols!!!
--------------------------------------+-------------------------------------
Reporter: aly.deines | Owner: davidloeffler
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-wishlist
Component: number fields | Keywords: hilbert symbol
Author: aly.deines | Upstream: N/A
Reviewer: | Merged:
Work_issues: ReST formatting issues |
--------------------------------------+-------------------------------------
Changes (by davidloeffler):
* work_issues: patch does not apply => ReST formatting issues
Comment:
I see. So it's supposed to be applied on top of the patches at #9317.
That's fine, but you should explain this in your trac upload messages.
Don't repost random patches from other tickets on this ticket -- that's
just unnecessary duplication, and it's confusing for the release
maintainer when s/he has to merge stuff later.
Anyway: with the #9317 patches in place these four patches apply fine, and
all doctests pass. But they're quite hard to review, since you seem to
have added code in one place in the first patch and then removed it and
added it again somewhere else in the second. Could I suggest that you use
the Mercurial "qfold" command to combine the four patches into one single
patch? That would make the reviewer's job vastly easier. And don't forget
those docstring formatting problems; the two that stand out most at a
quick glance are that the LaTeX formulae should be in backticks not dollar
signs ({{{`x^2 + 2`}}} etc), and the LaTeX fraction command is {{{\frac}}}
not {{{\frak}}}.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9334#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
