#9372: implement regulator function for elliptic curves over number fields
-------------------------------+--------------------------------------------
   Reporter:  cremona          |       Owner:  cremona   
       Type:  enhancement      |      Status:  needs_work
   Priority:  major            |   Milestone:  sage-4.5  
  Component:  elliptic curves  |    Keywords:            
     Author:  John Cremona     |    Upstream:  N/A       
   Reviewer:                   |      Merged:            
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by davidloeffler):

  * status:  needs_review => needs_work


Comment:

 I'm getting a couple of doctest failures -- something is off by a sign in
 the {{{height_pairing_matrix}}} code:
 {{{
 sage -t -long ell_number_field.py
 **********************************************************************
 File "/storage/masiao/sage-4.4.4/devel/sage-
 reviewing/sage/schemes/elliptic_curves/ell_number_field.py", line 308:
     sage: E.height_pairing_matrix([P,Q])
 Expected:
     [ 0.686667083305587 -0.268478098806726]
     [-0.268478098806726  0.327000773651605]
 Got:
     [0.686667083305587 0.268478098806726]
     [0.268478098806726 0.327000773651605]
 **********************************************************************
 File "/storage/masiao/sage-4.4.4/devel/sage-
 reviewing/sage/schemes/elliptic_curves/ell_number_field.py", line 317:
     sage: EK.height_pairing_matrix([EK(P),EK(Q)])
 Expected:
     [ 0.686667083305586 -0.268478098806726]
     [-0.268478098806726  0.327000773651605]
 Got:
     [0.686667083305586 0.268478098806726]
     [0.268478098806726 0.327000773651605]
 **********************************************************************
 1 items had failures:
    2 of  23 in __main__.example_4
 ***Test Failed*** 2 failures.
 }}}

 Also, a very tiny quibble: the second argument "precision" to
 {{{height_pairing_matrix}}} is missing its bullet point in the docstring.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9372#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to