#9342: rank method for elliptic curves over number fields
---------------------------------------------------------+------------------
   Reporter:  ljpk                                       |       Owner:  
cremona     
       Type:  enhancement                                |      Status:  
needs_review
   Priority:  minor                                      |   Milestone:  
sage-4.5    
  Component:  elliptic curves                            |    Keywords:         
     
     Author:  Lloyd Kilford, Alyson Deines, Jeremy West  |    Upstream:  N/A    
     
   Reviewer:  David Loeffler                             |      Merged:         
     
Work_issues:  docstring formatting                       |  
---------------------------------------------------------+------------------
Changes (by newvalueoldvalue):

  * status:  needs_work => needs_review
  * reviewer:  => David Loeffler
  * author:  ljpk => Lloyd Kilford, Alyson Deines, Jeremy West


Comment:

 Perhaps I was being a bit harsh: most of the ReST formatting errors were
 already present in the docstring of {{{simon_two_descent}}}, so they're
 not your fault. I've done a small patch which fixes these, and also
 slightly changes the behaviour of {{{rank}}} when 2-descent doesn't
 precisely nail the rank down (in the original version, it didn't report
 the upper and lower bounds in the error message, although the docstring
 claimed it did).

 If you're happy with my changes, then feel free to set this to "positive
 review".

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9342#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to