#9267: Update the charge statistic on words
-----------------------------+----------------------------------------------
   Reporter:  jbandlow       |       Owner:  sage-combinat          
       Type:  defect         |      Status:  needs_work             
   Priority:  major          |   Milestone:  sage-4.5               
  Component:  combinatorics  |    Keywords:  words, charge, cocharge
     Author:  Jason Bandlow  |    Upstream:  N/A                    
   Reviewer:                 |      Merged:                         
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by saliola):

  * status:  needs_review => needs_work


Comment:

 Tested against sage-4.4.4. Patch applies cleanly. All tests pass. The code
 looks good.

 Just a few documentation issues:

 - Add a line break here:
 {{{
  r"""Implements Lascoux and Schutzenberger's `s_i` operator, swapping
 }}}

 - Please add a reference in the documentation to an article or book that
 defines charge, cocharge, Lascoux and Schutzenberger's `s_i` operators,
 etc.

 - Since this definition of charge differs from that found in Macdonald's
 book, and since Sage uses many of Macdonald's conventions, I think it is a
 good idea to add a warning in the docstring of charge that explains that
 this is the common definition found in the literature and that it differs
 from that in Macdonald's book.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9267#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to