#8950: new function for sage.calculus.desolve module
------------------------------+---------------------------------------------
Reporter: uri | Owner: burcin
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.5
Component: calculus | Keywords: desolve
Author: Oriol Castejon | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by uri):
* status: needs_work => needs_review
Comment:
After a while, I've been able to make the changes proposed by burcin (by
the way, thanks for your suggestions):
* use 4 spaces for indentation -> Done
* try not to have lines exceeding 80 characters (some of us use old
fashioned command line editors) -> Done, except for a line in the
examples. I couldn't break that line, because then the automatic testing
wouldn't work. I guess it's not a big deal, since it is not part of the
code, though.
* change the ComputeJacobian argument -> Done
* Your function doesn't seem to do anything, comparing with the
previous[attachment:desolve_numerical.py
attachment:desolve_numerical.py] a whole chunk of code starting with
the `else` clause corresponding to the second `if` statement seems to be
missing -> I don't get your point here... I think there's no problem with
the second if statement. Could you be more precise?
* You should use y[:] to copy a list -> Done
* Other functions in the same file also solve differential equations
numerically. Choosing a more specific name for your function might be more
appropriate. -> You're right. I changed the name to '''desolve_odeint''',
since the it uses the integrate function from odeint module (from scipy).
I will be grateful for any other comments!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8950#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
