#9370: customize printing of elements in CombinatorialFreeModules
-----------------------------+----------------------------------------------
   Reporter:  jhpalmieri     |       Owner:  sage-combinat
       Type:  enhancement    |      Status:  needs_review 
   Priority:  major          |   Milestone:  sage-4.5     
  Component:  combinatorics  |    Keywords:               
     Author:  John Palmieri  |    Upstream:  N/A          
   Reviewer:                 |      Merged:               
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):

  * status:  needs_work => needs_review


Comment:

 Replying to [comment:1 saliola]:
 > Hello John,

 Thanks for your comments.

 > basis_keys provides the indexing set for the basis, not the basis
 itself.

 Fixed.

 > ``element_class``: I understand that the default argument is None, but
 it would be nice to
 > have a description of the class used in that case since elements are not
 > instances of None.

 Fixed, I think.

 > It doesn't say here, but it seems that prefix and latex_prefix are
 supposed
 > to be strings. Or anything that concatenates with a string (for example,
 I
 > think any instance of LatexExpr will work).

 I've documented that they should be strings.  It's true that a
 {{{LatexExpr}}} will work, but I don't think we need to spell that out.

 > ``repr_bracket``: Please describe what bracket gets used with the
 default option. Also, the
 > code sets the default to None, not True.

 I've expanded on the explanation here.

 > And perhaps a method called print_options might be useful (instead of
 pointing the user to an "internal" attribute). With no arguments, it will
 return _print_options and otherwise it will set the appropriate option.

 Good idea, I've implemented this.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9370#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to