#9097: c_lib in Sage library fails to build on OpenSolaris x64
----------------------------+-----------------------------------------------
   Reporter:  drkirkby      |       Owner:  fbissey     
       Type:  defect        |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.5    
  Component:  solaris       |    Keywords:              
     Author:  David Kirkby  |    Upstream:  N/A         
   Reviewer:                |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by fbissey):

  * owner:  drkirkby => fbissey


Comment:

 I think the patch does the job. But I want to suggest the following patch
 (sorry I
 have broken browsers right now because of a messy libpng update and I
 cannot use the
 attachment form):

 {{{
 --- SConstruct.orig     2010-05-26 12:13:50.000000000 +1200
 +++ SConstruct  2010-07-01 13:28:53.605754354 +1200
 @@ -105,15 +105,15 @@
  ## The other two options control the way the linker creates a namespace
  ## for the dynamic library; check the man page for ld on a mac to see
  ## the details.
 +if os.environ['SAGE64']=="yes":
 +    # We want the debug and optimization flags, since debug symbols are
 so useful, etc.
 +    print "MacIntel in 64 bit mode"
 +    env.Append( CFLAGS="-O2 -g -m64" )
 +    env.Append( CXXFLAGS="-O2 -g -m64" )
 +    env.Append( LINKFLAGS="-m64" )
 +
  if env['PLATFORM']=="darwin":
 -    if os.environ['SAGE64']=="yes":
 -        # We want the debug and optimization flags, since debug symbols
 are so useful, etc.
 -        print "MacIntel in 64 bit mode"
 -        env.Append( CFLAGS="-O2 -g -m64" )
 -        env.Append( CXXFLAGS="-O2 -g -m64" )
 -        env.Append( LINKFLAGS="-m64 -single_module -flat_namespace
 -undefined dynamic_lookup" )
 -    else:
 -        env.Append( LINKFLAGS="-single_module -flat_namespace -undefined
 dynamic_lookup" )
 +    env.Append( LINKFLAGS="-single_module -flat_namespace -undefined
 dynamic_lookup" )

  # SCons doesn't automatically pull in system environment variables
  # However, we only need SAGE_LOCAL, so that's easy.
 }}}
 I think this simplify the logic. The building of extension afterwards is
 separate.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9097#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to