#9371: Implement E.two_torsion_rank() over number fields
-------------------------------+--------------------------------------------
   Reporter:  weigandt         |       Owner:  weigandt                         
       Type:  task             |      Status:  needs_work                       
   Priority:  major            |   Milestone:  sage-4.5                         
  Component:  elliptic curves  |    Keywords:  elliptic curves, two torsion rank
     Author:  Jamie Weigandt   |    Upstream:  N/A                              
   Reviewer:  John Cremona     |      Merged:                                   
Work_issues:                   |  
-------------------------------+--------------------------------------------
Changes (by cremona):

  * status:  needs_review => needs_work
  * reviewer:  => John Cremona


Comment:

 Looks good: a better method and more general.   However:  why not move the
 function all the way up to ell_field?  There's no reason at all why the
 same code would not work over any field of char. not 2, and even in char.
 2 (where the result is at most 0 or 1 for supersingular/ordinary curves,
 but so what).

 If you do that, add extra doctests over (say) finite fields.
 While you are at it, one thing about the docstring could be improved:  the
 short description should fit on one line, so cut it after E(K), and put
 the rest into a separate ALGORITHM block.

 "Needs work" sounds negative, so let me elaborate: this is good and with a
 tiny amount of work would be very good!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9371#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to