#5873: [patch] Fix matplotlib build on FreeBSD
----------------------------+-----------------------------------------------
Reporter: pjeremy | Owner: mabshoff
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.5
Component: freebsd | Keywords:
Author: Peter Jeremy | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Comment(by drkirkby):
Replying to [comment:5 pjeremy]:
> Unfortunately, a variant of this patch is still needed to support
FreeBSD later than FreeBSD6. Whilst #9202 means prepending SAGE_LOCAL
should no longer be necessary, additional OS-related lines are still
needed to support recent versions of FreeBSD.
If you wish to create one, I'll try to review it reasonably quickly. It
makes review a lot easier if you can include things inside
{{{
#ifdef FREEBSD
#endif
}}}
or if appropriate
{{{
#ifdef HAVE_BUGGY_GCC_ON_FREEBSD
#undef putchar
#endif
}}}
or similar. Otherwise, it requires the reviewer to have a much deeper
knowledge of the code to evaluate if the changes are desirable or not. If
it can be seen the changes only affect FreeBSD, then it will be much
easier to get a positive review. That's been my experience with Solaris
and !OpenSolaris related problems.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5873#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
