#9496: Crypto lattice basis generator
--------------------------------------------------+-------------------------
   Reporter:  rlindner                            |       Owner:  mvngu         
        
       Type:  enhancement                         |      Status:  new           
        
   Priority:  major                               |   Milestone:                
        
  Component:  cryptography                        |    Keywords:  cryptography, 
lattices
     Author:  Richard Lindner, Michael Schneider  |    Upstream:  N/A           
        
   Reviewer:                                      |      Merged:                
        
Work_issues:                                      |  
--------------------------------------------------+-------------------------

Comment(by malb):

 I think overall it looks fine, some small points:

  * I think the function is too specialised to be in the main namespace,
 how about crypto.generate_lattice ?
  * Could you break lines around 80 characters?
  * One shouldn't need to pass a seed, but instead just change the seed
 with set_random_seed()
  * Id' rename ntl_flag to ntl

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9496#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to