#9094: is_square and sqrt for polynomials and fraction fields
-----------------------------------------------------+----------------------
Reporter: robertwb | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.5.1
Component: algebra | Keywords:
Author: mderickx | Upstream: N/A
Reviewer: mstreng | Merged:
Work_issues: improve documentation, add more tests |
-----------------------------------------------------+----------------------
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* author: Robert Bradshaw => mderickx
* reviewer: John Cremona => mstreng
* type: defect => enhancement
* work_issues: doctest failure => improve documentation, add more tests
Old description:
> Depends on #9093 and probably also #9129 for correctness.
New description:
Implement is_square and sqrt for polynomials and fraction fields.
--
Comment:
Looks good. No time for a complete review right now, but here are some
remarks:
* Check spelling of your documentation, you probably don't mean "wether"
(=castrated sheep), but "whether" (spell checker doesn't help that much
here). "Requiered" has one "e" too much.
* Illustrate is_square(root = True) for the user by providing a square
example and a non-square example.
* The internal variable name ``is_sqrt`` is confusing, remove the "t".
* You write "This code is quite general, it could even be implemented for
all integral domains as soon as they have the is_square(root=True)
option", don't you mean "This code is quite general, it works for all
integral domains that have the is_square(root = True) option"?
* I think sqrt(self, extend = True, all = False, name=None ) should have
tests of all combinations of options and squareness, i.e: sq/non-sq,
extend True/False, all True/False = 2*2*2 = at least 8 examples. The
extend=True for a non-square should also have examples with name=None and
name=something.
* Perhaps include examples for more base fields?
* consider adding a few more spaces for readability thougout, e.g. around
"="
* "if root==True:", why not write "if root:"?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9094#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
