#8807: Adding support for morphisms to the category framework
---------------------------+------------------------------------------------
Reporter: SimonKing | Owner: Simon King
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.2
Component: categories | Keywords: morphisms functors categories
Author: Simon King | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
---------------------------+------------------------------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
* milestone: => sage-4.5.2
Comment:
I produced a new patch (I hope I got the {{{hg -qfold}}} command right).
The problem was:
* Some construction functors used to be defined on the wrong categories.
E.g., the {{{MatrixFunctor}}} was defined as a functor from Rings() to
Rings(), which is of course wrong if the number of rows is different from
the number of columns.
* In the good old times, every functor had a custom {{{__call__}}}
method. Therefore, it was not noticed that sometimes the return value did
not belong to the expected category.
* My default {{{__call__}}} method does check the output - and raises an
error if it is wrong.
* For some reason I forgot to run {{{sage -testall}}}
Solution:
* Be more careful with defining domain and codomain of the construction
functors.
* Run {{{make ptestlong}}}. Result:
{{{
All tests passed!
Total time for all tests: 4078.1 seconds
}}}
One remark concerning doctests. The genuinely new code (induced morphisms)
is doctested. In my patch, I however did not add tests for
sage.categories.pushout. This is done in #8800. I hope that the ticket
from #8800 still applies with the new patch that I posted here.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8807#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
