#9554: Doctest failure in SageNB's sageinspect.py with #8988
------------------------------+---------------------------------------------
Reporter: mpatel | Owner: jason, was
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-4.5.2
Component: notebook | Keywords:
Author: Leif Leonhardy | Upstream: N/A
Reviewer: Volker Braun | Merged:
Work_issues: |
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):
* cc: Tim, Dumol (added)
* reviewer: => Volker Braun
* status: needs_review => positive_review
* author: => Leif Leonhardy
Comment:
Yes, as mpatel already pointed out, the problematic doctest is in
`sagenb/misc/sageinspect.py` and not in `sage/misc/sageinspect.py`
(sage'''nb''' vs. sage). The latter is fixed by the patch in #8988, and
the former is fixed by leif's `trac_9554-fix_order_of_var_names-SageNB-
repo.patch`. Both patches make identical changes to code that is
duplicated in the notebook spkg.
Since the patch is clearly the right thing to do I'll give it a positive
review. Whoever does the next SageNB release, please add this patch. The
tracker bug for SageNB 0.8.2 is #9572 where this patch is already listed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9554#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
