#9588: Extend is_prime_power to negative exponents
--------------------------------+-------------------------------------------
Reporter: arminstraub | Owner: AlexGhitza
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-4.5.2
Component: basic arithmetic | Keywords: is_prime_power
Author: Armin Straub | Upstream: N/A
Reviewer: Carl Witty | Merged:
Work_issues: |
--------------------------------+-------------------------------------------
Changes (by cwitty):
* status: needs_review => positive_review
* reviewer: => Carl Witty
* milestone: => sage-4.5.2
Comment:
Code looks reasonable, doctests pass. Positive review.
Armin, thanks for sticking with this! To answer your questions:
(1) Opinions differ :) Sometimes it's nice to preserve the history of the
patch, but it's also nice to make it easier for reviewers and the release
manager by not having a whole sea of patches that they have to wade
through to figure out which to apply. In your case -- a simple rebase,
where nobody will probably ever care about previous versions of the patch
-- I'd say yes, replacing the old one is fine.
(2) Yes, if you think you've addressed the work issue you should remove
it.
Release manager: apply only the second patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9588#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
