#8469: add "Number Theory and the RSA Public Key Cryptosystem" to "Thematic
Tutorials"
-------------------------------+--------------------------------------------
Reporter: mvngu | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.2
Component: documentation | Keywords: RSA, public-key cryptosystem
Author: Minh Van Nguyen | Upstream: N/A
Reviewer: Pablo Angulo | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by mvngu):
When applying the previous version of my patch on top of Sage 4.5.2.rc0, I
got the following failure:
{{{
#!sh
[mv...@sage sage-main]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/8469/trac_8469-rsa.patch && hg qpush
adding trac_8469-rsa.patch to series file
applying trac_8469-rsa.patch
patching file doc/en/thematic_tutorials/index.rst
Hunk #1 FAILED at 13
1 out of 1 hunks FAILED -- saving rejects to file
doc/en/thematic_tutorials/index.rst.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh trac_8469-rsa.patch
}}}
I have rebased my patch against Sage 4.5.2.rc0 in order to resolve the
above failure.
[[BR]]
The content of pang's patch [attachment:trac_8469_review_final.patch] is
mostly OK, but the way the patch itself is structured is frowned upon.
From the way it looks, I guess that the patch was put together by
concatenating many patches together into one file. That's not how you
should put patches together. Use Mercurial queue to concatenate patches
into one patch. I have done this and uploaded an updated version of pang's
patch, which also fixes some typos found in his original patch. For
reference, here are the fixed typos:
{{{
#!diff
--- a/doc/en/thematic_tutorials/numtheory_rsa.rst
+++ b/doc/en/thematic_tutorials/numtheory_rsa.rst
@@ -295,8 +295,8 @@
pseudo-random integer uniformly distributed within the closed interval
`[0, n-1]`.
-We can compute the value `\varphi(n)` calling the sage function
-``euler_phi(n)``, but for arbitrary large prime numbers `p` and `q`,
+We can compute the value `\varphi(n)` by calling the sage function
+``euler_phi(n)``, but for arbitrarily large prime numbers `p` and `q`,
this can take an enormous amount of time. Indeed, the private key
can be quickly deduced from the public key once you know `\varphi(n)`,
so it is an important part of the security of the RSA cryptosystem that
}}}
Pang's updated patch and the typo fixes are all rolled into one patch. See
the ticket description for instructions on applying the relevant patches.
[[BR]]
For ticket to be closed, the following must happen:
1. Someone needs to sign off on [attachment:trac_8469-rsa.patch]. This is
my patch, so it requires a reviewer other than myself.
1. Someone needs to sign off on [attachment:trac_8469-review-
rebased.patch]. This is pang's original patch together with some typo
fixes by me. I'm happy with pang's content. But someone other than myself
needs to go over the fixes I included in this updated patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8469#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
