#9681: Missing dependancy in spkg/standard/deps for zn_poly.
------------------------+---------------------------------------------------
   Reporter:  drkirkby  |       Owner:  GeorgSWeber
       Type:  defect    |      Status:  new        
   Priority:  blocker   |   Milestone:  sage-4.5.2 
  Component:  build     |    Keywords:             
     Author:            |    Upstream:  N/A        
   Reviewer:            |      Merged:             
Work_issues:            |  
------------------------+---------------------------------------------------
Description changed by drkirkby:

Old description:

> The zn_poly package lists in {{{SPKG.txt}}} the only dependencies are
> GMP, but this is not true, as zn_poly's configure script has in it:
>
> {{{
> /configure --gmp-prefix="$SAGE_LOCAL" --ntl-prefix="$SAGE_LOCAL" \
>             --prefix="$SAGE_LOCAL" --cflags="$CFLAGS"
> --ldflags="$LDFLAGS"
> }}}
>
> Looking at $SAGE_ROOT/spkg/standard/deps, I see:
>
> {{{
> $(INST)/$(ZNPOLY): $(BASE) $(INST)/$(MPIR)
>         $(INSTALL) "$(SAGE_SPKG) $(ZNPOLY) 2>&1" "tee -a
> $(SAGE_LOGS)/$(ZNPOLY).log"
> }}}
>
> then looking at MPIR I see the dependencies are only BASE and ICONV. But
> ICONV only depends on BASE, so there is nothing to force ntl to build
> before zn_poly.
>
> I am aware of two other changes that are desirable in the 'deps' file
> too, as they add clarity.
>
>  * #9464
>  * #9637
>
> These might as well be fixed at the same time.
>
> Dave

New description:

 The zn_poly package lists in {{{SPKG.txt}}} the only dependencies are GMP,
 but this is not true, as zn_poly's configure script has in it:

 {{{
 /configure --gmp-prefix="$SAGE_LOCAL" --ntl-prefix="$SAGE_LOCAL" \
             --prefix="$SAGE_LOCAL" --cflags="$CFLAGS" --ldflags="$LDFLAGS"
 }}}

 '''So zn_poly depends on ntl'''

 Looking at $SAGE_ROOT/spkg/standard/deps, I see:

 {{{
 $(INST)/$(ZNPOLY): $(BASE) $(INST)/$(MPIR)
         $(INSTALL) "$(SAGE_SPKG) $(ZNPOLY) 2>&1" "tee -a
 $(SAGE_LOGS)/$(ZNPOLY).log"
 }}}

 i.e. no such dependency is directly listed.

 Then looking at MPIR I see the dependencies are only BASE and ICONV. But
 ICONV only depends on BASE, '''so there is nothing to force ntl to build
 before zn_poly, despite zn_poly depends on ntl'''

 I am aware of two other changes that are desirable in the 'deps' file too,
 as they add clarity.

  * #9464
  * #9637

 These might as well be fixed at the same time.

 Dave

--

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9681#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to