#9684: Make use of _tidy_model() optional
-------------------------------+--------------------------------------------
Reporter: arminstraub | Owner: cremona
Type: enhancement | Status: needs_review
Priority: minor | Milestone:
Component: elliptic curves | Keywords: local_data
Author: Armin Straub | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-------------------------------+--------------------------------------------
Comment(by cremona):
The first patch is fine, applies to 4.5.3.alpha0 and tests pass.
I added a second patch which **only** changes "tidy" to "reduce" as
appropriate, which I think is better terminology. If the original poster
is happy with that, please mark the ticket "positive review". If not,
I'll still give the first patch a positive review.
For the future, there is an addition reduction step not yet implemented
but useful (only non-trivial over number fields): scale by [u,0,0,0]
where u is a unit chosen so that the discriminant is in a sense minimal
(minimal height modulo 12th powers of units). But that is for another
day.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9684#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.