#7154: options for point/arrow thickness are inconsistently named
------------------------+---------------------------------------------------
Reporter: vbraun | Owner: was
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.5.3
Component: graphics | Keywords: point arrow thickness, beginner
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------+---------------------------------------------------
Changes (by jason):
* status: needs_review => needs_work
Comment:
Thanks! Fixing things like this really add to the polish and ease-of-use
of Sage, and make it much more user-friendly.
Three comments:
1. I think the rename_keyword works the other way. See this example from
the docs:
{{{
rename_keyword(deprecated='Sage version 4.2',
deprecated_option='new_option')
}}}
Don't you want it to be thickness='width'? Also, the actual keyword in
the function should be changed in the function declaration (you can
probably then search and replace in the function definition to replace
'thickness' with 'width'.
2. Could you add a deprecation by using the deprecation feature of
rename_keyword?
3. Could you add a short doctest showing the deprecation warning and the
new option? The deprecation warning should probably be in a TESTS:
section, while the new option should definitely be in the EXAMPLES
section.
Thanks for working on this!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7154#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
