#9301: Modified check_edge_label in the sparse graph backend to consider equals
the same objects rather than objects with the same contents
---------------------------------+------------------------------------------
   Reporter:  comick             |       Owner:  jason, mvngu, ncohen, rlm
       Type:  defect             |      Status:  needs_work               
   Priority:  minor              |   Milestone:  sage-4.5.3               
  Component:  graph theory       |    Keywords:  graph,label              
     Author:  Michele Comignano  |    Upstream:  N/A                      
   Reviewer:                     |      Merged:                           
Work_issues:                     |  
---------------------------------+------------------------------------------
Changes (by rlm):

  * status:  needs_review => needs_work
  * upstream:  Workaround found; Bug reported upstream. => N/A


Comment:

 There is a fly in the ointment:

 During one of the last NetworkX upgrades, many common Sage graph
 constructors were modified to give empty dictionaries as labels instead of
 None. I have been intending to fix many of Sage's graph generators not to
 depend on NetworkX (since simply constructing a CGraph would be much
 quicker), and revert the edge situation back to having labels equal to
 `None`. But until that happens, this patch causes several failures:

 {{{
 sage -t -long "devel/sage-main/sage/graphs/generic_graph.py"
 sage -t -long "devel/sage-main/sage/graphs/base/sparse_graph.pyx"
 sage -t -long "devel/sage-main/sage/graphs/graph.py"
 }}}

 Also, I've changed the "Report Upstream" since here we *are* the upstream.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9301#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to