#9754: Add random unimodular and subspaces matrices to matrix/constructor.py
----------------------------------------+-----------------------------------
Reporter: bwonderly | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.5.3
Component: linear algebra | Keywords:
Author: Billy Wonderly | Upstream: N/A
Reviewer: David Joyner, Rob Beezer | Merged:
Work_issues: |
----------------------------------------+-----------------------------------
Changes (by rbeezer):
* status: needs_work => needs_review
* reviewer: => David Joyner, Rob Beezer
Comment:
The v6 patch looks real good - corrects rows/columns bug, fixes up the
rank-nullity-confusion, and streamlines the end of the code for the
"subspaces" routine (with comments replacing code for explanation). Works
well, passes all tests and docs look good.
I noticed one test in the "echelonizable" routine that talks about "just
building a zero matrix" if you need it (I'd added that verbiage earlier).
Its gone in v7, that's the only change. v7 patch still has Billy's name
in it and is the full patch otherwise.
I think this is done, at least I am checking-off on the changes leading to
the v6 patch.
Billy - you could/should sign off on the little change to make v7.
David - you can weigh-in further if you like, or not. If so, we can leave
this open for a few days. If not, we'll wrap this all up. Thanks so much
for all your help and encouragement reviewing Billy's summer project.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9754#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
