#9699: Barycentric embedding for planar graphs.
----------------------------------+-----------------------------------------
   Reporter:  fidelbarrera        |       Owner:  jason, ncohen, rlm
       Type:  enhancement         |      Status:  needs_review      
   Priority:  major               |   Milestone:  sage-4.6          
  Component:  graph theory        |    Keywords:                    
     Author:  Fidel Barrera-Cruz  |    Upstream:  N/A               
   Reviewer:                      |      Merged:                    
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by ncohen):

 > I think the previous implementation features interesting properties. It
 provided a straightline embedding in an O(n) by O(n) grid, so in
 particular all the coordinates are integers. Would you still suggest to
 replace the code completely?

 No, not anymore... But now I would suggest to mention these properties in
 the docstring. Sorry for asking it this late, but I am concerned about
 avoiding to have in Sage at the same time two pieces of code doing the
 same thing in different ways, and writing it in such a way that one of
 them is never used.. That's why I wondered whether it would be better to
 completely replace the current implementation with yours instead of having
 two version. If the current version has properties that yours do not have,
 then you are right : it should remain available, but this is not very
 useful if nobody knows these properties exists.... Hence, where you
 documented the keyword ``barycentric``

 {{{
 - ``barycentric`` - whether or not to use barycentric coordinates.
 }}}

 it would be nice to also mention that setting it to ``None`` means having
 an embedding in a O(n)*O(n) grid with integer coordinates, as you just
 taught me.. Otherwise it's very unlikely people would disable a feature
 with no computation time to earn...nothing `:-)`

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9699#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to