#9383: Add quadratic forms code to the reference manual
--------------------------------------------+-------------------------------
Reporter: annahaensch | Owner: mvngu
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.6
Component: documentation | Keywords: quadratic forms
Author: Anna Haensch, David Loeffler | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
--------------------------------------------+-------------------------------
Comment(by davidloeffler):
Replying to [comment:7 mvngu]:
> The attachment make numerous ReST changes to the following modules, but
does not add them to the reference manual:
>
> {{{
> sage/quadratic_forms/quadratic_form__automorphisms.py
> sage/quadratic_forms/quadratic_form__count_local_2.py
> sage/quadratic_forms/quadratic_form__equivalence_testing.py
> sage/quadratic_forms/quadratic_form__genus.py
> sage/quadratic_forms/quadratic_form__local_density_congruence.py
> sage/quadratic_forms/quadratic_form__local_density_interfaces.py
> sage/quadratic_forms/quadratic_form__local_field_invariants.py
> sage/quadratic_forms/quadratic_form__local_normal_form.py
> sage/quadratic_forms/quadratic_form__local_representation_conditions.py
> sage/quadratic_forms/quadratic_form__mass.py
> sage/quadratic_forms/quadratic_form__mass__Conway_Sloane_masses.py
> sage/quadratic_forms/quadratic_form__mass__Siegel_densities.py
> sage/quadratic_forms/quadratic_form__neighbors.py
> sage/quadratic_forms/quadratic_form__reduction_theory.py
> sage/quadratic_forms/quadratic_form__siegel_product.py
> sage/quadratic_forms/quadratic_form__split_local_covering.py
> sage/quadratic_forms/quadratic_form__ternary_Tornaria.py
> sage/quadratic_forms/quadratic_form__theta.py
> sage/quadratic_forms/quadratic_form__variable_substitutions.py
> }}}
>
> The [attachment:trac_9383_v4.patch] receives a positive review as is. If
you want, you could open another ticket to add the missing modules to the
reference manual.
No, there is no need to do this. The functions from those modules are all
imported into quadratic__form.py; they are divided into separate modules
solely in order to keep the size of the top-level file manageable. The
ReST parser follows these imports, so adding the separate files to the
manual as well would just mean everything was in there twice.
Thanks for the review, anyway!
David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9383#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
