#9835: Make desolve more informative when solving BVP
--------------------------------------------------------------------+-------
Reporter: robert.marik |
Owner: mhampton
Type: defect |
Status: needs_review
Priority: minor |
Milestone: sage-4.6.1
Component: calculus |
Keywords:
Author: Robert Marik |
Upstream: N/A
Reviewer: Karl-Dieter Crisman, Burcin Erocal, Marshall Hampton |
Merged:
Work_issues: |
--------------------------------------------------------------------+-------
Changes (by newvalueoldvalue):
* reviewer: => Karl-Dieter Crisman, Burcin Erocal, Marshall Hampton
* author: => Robert Marik
Comment:
Patch looks good and it solves a whole bunch of problems, so I'd like to
give this a positive review.
I have one minor suggestion. The if clause on line 435-436 only serves the
purpose of assigning a value to `maxima_method` to show in the error
message. attachment:trac_9835.take2.patch moves these lines right before
we raise the error, so that they are not executed unnecessarily.
I give a positive review to Robert's changes. Please switch this to a
positive review if you agree with mine.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9835#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
