#9877: Add is_sturmian_factor, is_tangent methods for finite words
-----------------------------+----------------------------------------------
   Reporter:  tmonteil       |       Owner:  tmonteil  
       Type:  enhancement    |      Status:  needs_work
   Priority:  major          |   Milestone:  sage-4.6  
  Component:  combinatorics  |    Keywords:            
     Author:                 |    Upstream:  N/A       
   Reviewer:                 |      Merged:            
Work_issues:                 |  
-----------------------------+----------------------------------------------
Changes (by abmasse):

  * status:  needs_review => needs_work


Comment:

 I'm testing your patch in the next two hours. Before testing it
 explicitly, just some comments:

  1. Could you add a reference where one can find the proof that a word is
 finite sturmian if and only if you can desubstitute it to the empy word?
  1. As I told you when you were in Montreal, I think I prefer the name
 `is_finite_sturmian` (or just `is_sturmian`) over the name
 `is_sturmian_factor`. I feel that the last one implies an argument like in
 `w.is_sturmian_factor(u)` and it seems to be used in many articles (just
 googling it, you find a big list).
  1. Not very important, but there are two comment `# print <something>`
 that should be removed from the code in the function `is_sturmian_factor`.

 I'm waiting for sage-combinat to install and I'll test and look more
 thoroughly at your code.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9877#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to